CI: bump nx to v23.0.1 and use its cache between runs#34105
Draft
EugeniyKiyashko wants to merge 2 commits into
Draft
CI: bump nx to v23.0.1 and use its cache between runs#34105EugeniyKiyashko wants to merge 2 commits into
EugeniyKiyashko wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enable Nx local caching in CI/build scripts to speed up repeated builds and test runs across the DevExtreme monorepo workflows.
Changes:
- Removed
--skipNxCachefrom build scripts and enabled caching for key Nx targets. - Added
.nx/cachepersistence via GitHub Actions cache in multiple workflows and introduced workflow-level concurrency cancellation for some pipelines. - Refined demo lint targets/inputs and increased default TestCafe concurrency.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 21 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/build-all.ts | Removes forced cache bypass for build-dist and themebuilder build to allow Nx caching. |
| packages/devextreme/project.json | Marks build and build-dist targets as cacheable. |
| packages/devextreme-themebuilder/project.json | Expands inputs/outputs for themebuilder build and enables caching. |
| e2e/testcafe-devextreme/runner.ts | Increases default TestCafe runner concurrency. |
| apps/demos/project.json | Refines lint target inputs, adds lint-demos, and excludes large artifact folders from lint-html inputs. |
| apps/demos/package.json | Switches lint to Nx run-many including the new lint-demos target. |
| apps/demos/.prettierignore | Ignores testing/artifacts to avoid formatting generated artifacts. |
| .github/workflows/wrapper_tests.yml | Adds concurrency cancellation and Nx cache restore/save. |
| .github/workflows/wrapper_tests_e2e.yml | Adds Nx cache restore/save. |
| .github/workflows/visual-tests-demos.yml | Adds Nx cache restore/save; adjusts jQuery matrix generation and concurrency. |
| .github/workflows/testcafe_tests.yml | Adds Nx cache restore/save; generates matrix dynamically and tweaks TestCafe args. |
| .github/workflows/themebuilder_tests.yml | Adds Nx cache restore/save. |
| .github/workflows/styles.yml | Adds Nx cache restore/save. |
| .github/workflows/renovation.yml | Adds Nx cache restore/save. |
| .github/workflows/qunit_tests.yml | Adds Nx cache restore/save. |
| .github/workflows/publish-demos.yml | Adds Nx cache restore/save. |
| .github/workflows/pr-storybook-deploy.yml | Splits pnpm vs Nx cache steps and adds Nx cache restore/save. |
| .github/workflows/pr-storybook-deploy-manual.yml | Adds Nx cache restore/save. |
| .github/workflows/playgrounds_tests.yml | Adds Nx cache restore/save to build and matrix test jobs. |
| .github/workflows/lint.yml | Adds Nx cache restore/save across lint jobs. |
| .github/workflows/demos_unit_tests.yml | Adds Nx cache restore/save. |
| .github/workflows/default_workflow.yml | Adds Nx cache restore/save. |
| .github/workflows/build_all.yml | Adds concurrency cancellation and Nx cache restore/save. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 44 out of 48 changed files in this pull request and generated 3 comments.
Files not reviewed (4)
- apps/demos/Demos/Diagram/AdvancedDataBinding/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithIcons/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplates/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/test-code.js: Generated file
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 44 out of 48 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- apps/demos/Demos/Diagram/AdvancedDataBinding/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithIcons/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplates/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/test-code.js: Generated file
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 44 out of 48 changed files in this pull request and generated 3 comments.
Files not reviewed (4)
- apps/demos/Demos/Diagram/AdvancedDataBinding/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithIcons/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplates/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/test-code.js: Generated file
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 44 out of 48 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- apps/demos/Demos/Diagram/AdvancedDataBinding/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithIcons/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplates/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/test-code.js: Generated file
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 44 out of 48 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- apps/demos/Demos/Diagram/AdvancedDataBinding/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithIcons/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplates/test-code.js: Generated file
- apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/test-code.js: Generated file
EugeniyKiyashko
force-pushed
the
26_1_nx_cache
branch
from
47fda5e to
10bec97
Compare
EugeniyKiyashko
force-pushed
the
26_1_nx_cache
branch
2 times, most recently
from
661cec3 to
ce4f7d4
Compare
EugeniyKiyashko
changed the title
EugeniyKiyashko
force-pushed
the
26_1_nx_cache
branch
from
ce4f7d4 to
8097ab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.